Conversation
|
Puzzled on why you are updating all the other languages compiled translations, and please rebase :) |
alanmcruickshank
force-pushed
the
translate_german
branch
2 times, most recently
from
c7e4143 to
682ded8
Compare
|
Rebased and conflicts resolved. |
superset/config.py
Outdated
There was a problem hiding this comment.
I'm confused and wondering how it worked before or what broke this.
There was a problem hiding this comment.
Yeah I thought the same. It took me a while to set up my environment and this was one thing I changed of a few to get things working - so this change is not necessary. That being said there isn't a babel/translations path that I could see.
I've just done a quick test and the translations work with either value.
Vanilla FAB has the path as just translations
https://github.com/dpgaspar/Flask-AppBuilder/blob/af095ac4094d068fa2dd467bd01fa8b95d697fc1/examples/quickfiles/config.py
I suspect in our docs we always get people to specify the path as superset/translations in all the scripts for generating translations so even if the value we had before wasn't correct we were always overwriting it. I've done some quick testing and I actually suspect in most cases this line isn't used.
There was a problem hiding this comment.
That being said - given it doesn't matter. I'm happy to just leave it as it is if you'd rather.
|
Coverage remained the same at 71.271% when pulling 682ded88a8646f7e063458993ff13898e6d058d3 on alanmcruickshank:translate_german into 1e18bfd on apache:master. |
1 similar comment
|
Coverage remained the same at 71.271% when pulling 682ded88a8646f7e063458993ff13898e6d058d3 on alanmcruickshank:translate_german into 1e18bfd on apache:master. |
|
Will merge upon conflict resolved |
Not complete but most of the core interface
alanmcruickshank
force-pushed
the
translate_german
branch
from
682ded8 to
3e65fbb
Compare
|
@mistercrunch - I've removed the edits to messages.pot as they're superceded by the translation consolidation in #3750. Rebased onto current master. |
Not complete but most of the core interface
Not complete but most of the core interface
mistercrunch
added
🏷️ bot
4 participants
Not a full German translation but most of the core interface. Updated the
BABEL_DEFAULT_FOLDERconfig flag which appeared to be pointing at the wrong folder.Update the standard messages files in the process.